StoreKit bug. Incomplete "requestProductsComplete" event

amaximov

When offline(no wifi or mobile data), the only keys the event table has when calling store kit:requestProducts() are __target, __type, and __userdata. Seems like there should be at least 2 more, "error" and "errorDescription" as according to documentation.

When online, event seems to be working just fine.

However it really is a pitty with this bug that there is no indication of the error in the case of an error. I actually check if the event is an error and only if it isnt do i go through and process the event.products table. However, since there is no indication of an error, my app just crashed when it thinks there is no error and tries to access a non existent event.products table.

And yes my workaround is too just check if event.products table exists but nonetheless still a bug Still lovin Gideros regardless!

ar2rsawseen

noted

atilim

@amaximov I've checked and when the device is offline errorCode -1009 and errorDescription "Cannot connect to iTunes Store" are passed with event table.

Here is my sample code:

require "storekit"   storekit:addEventListener(Event.REQUEST_PRODUCTS_COMPLETE, function(event) print(event.errorCode, event.errorDescription) end)   storekit:requestProducts({"foo"})

Can you check again?

alexzheng

when wifi is turned off，no error code

amaximov

I'll look into it soon and check in with you guys.

atilim

hmm. I was lazy and have done the test on Xcode simulator Let me also do the test on a real device.

atilim

You're right. When the internet is offline productsRequest:didReceiveResponse: can be called instead of request:didFailWithError:. http://stackoverflow.com/questions/14251345/should-productsrequestdidreceiveresponse-run-when-there-is-no-internet-connect http://www.cocos2d-iphone.org/forums/topic/should-i-check-for-an-internet-connection-before-i-request-products-from-apple/

I think it's a bug (feature?) of Apple but it's possible to add a workaround to storekit.mm. If you want, you can update productsRequest:didReceiveResponse: function as:

- (void)productsRequest:(SKProductsRequest*)request didReceiveResponse:(SKProductsResponse*)response { if (response.products == nil || response.invalidProductIdentifiers == nil) { NSError *error = [NSError errorWithDomain:<a href="https://forum.gideros.rocks/profile/NSURLErrorDomain" rel="nofollow">@NSURLErrorDomain</a> code: -1009 userInfo:nil]; dispatchEvent(L, REQUEST_PRODUCTS_COMPLETE, error, NULL, NULL, NULL); } else { dispatchEvent(L, REQUEST_PRODUCTS_COMPLETE, NULL, response.products, response.invalidProductIdentifiers, NULL); }   [request release]; }

amaximov

Thanks Atilim! I'll implement it in my next update! On another note, how's the 2.0 release of Gideros going?

ar2rsawseen

Currently it's not going, decided to release one more pre Gideros 2.0 version to community with all the needed features included (like native json, etc) before going for full Gideros 2.0 development

amaximov

Do you know when this next pre 2.0 version will be ready?