ImGui new thread

keszegh

is there any way to update the buffer of an inputtext upon isItemActivated? that would be simplest. i tried more complicated stuff, e.g. have a callback with ImGui.InputTextFlags_CallbackAlways which checks a 'first' flag and if it is true then it sets buffer to full text and changes this flag, but for some reason it does not work:

local function inputTextCallback(data) if not self.isDirEdited then print("dir"..currentDir) data:setBuf(currentDir) data:setBufDirty(true) end self.isDirEdited=true end     self.currentDirTruncated, flag = imgui:inputText("###Path", self.currentDirTruncated, 256, ImGui.InputTextFlags_CallbackAlways, inputTextCallback) if imgui:isItemDeactivatedAfterEdit() then self.isDirEdited=false end

keszegh

also i'd want to put the cursor at the very end of the text when one clicks on it and starts editing. this i also don't know how to do.

rrraptor

keszegh said:

@rrraptor , the latest dll seriously messed up something with textures....

EDIT: please reup the old one quickly as now i'm stuck, i cannot go back to gideros-version due to different syntax of functions while this latest version is also impossible to use.

I have no idea what happened
It ok for me (single texture):

TextureRegion:

Check if you have extra parameters to any "scaledImageXXX" function at the end. Like this:

Note 0 as last param.

keszegh said:

also i'd want to put the cursor at the very end of the text when one clicks on it and starts editing. this i also don't know how to do.

I guess its impossible.

keszegh said:

this leads to a crash (if i comment out one of keys/mouse it still crashes, if i change suspend to resume, it still crashes).

Download this tool: https://docs.microsoft.com/en-us/sysinternals/downloads/debugview
and see what is written there at the time of the crash.
Should look something like this:



No problems for me aswell

keszegh

"Check if you have extra parameters to any "scaledImageXXX" function at the end. Like this:"
-this helped, as i've overloaded it in my padded version. thanks (although it's strange that additional params mess it up)

" I guess its impossible to put cursor at end of text. " - strange.

about the suspend crash actually there is a gideros log too, i forgot to share:
Assertion failed!

Program: C:\Program Files (x86)\Gideros\GiderosPlayer.exe
File: refptr.cpp, Line 67

Expression: refcount_ == 1
AL lib: ALc.c:2325: exit(): closing 1 Device
AL lib: ALc.c:2247: alcCloseDevice(): destroying 1 Context(s)

keszegh

you've recommended to replace my image+text with ImageWithText. actually my items are selectables, can one make an imagewithtext (or an image) part of the selectable?

(now when i hover on my image+selectable it highlights the text part but not the image, ideally it would also highlight the image background too, so i'm not 100% with my current solution anyway). see screenshot.

rrraptor

keszegh said:

"Check if you have extra parameters to any "scaledImageXXX" function at the end. Like this:"
-this helped, as i've overloaded it in my padded version. thanks (although it's strange that additional params mess it up)

Last 4 arguments stands for visible area:
http://forum.giderosmobile.com/discussion/comment/65421/#Comment_65421
So its now:

ImGui:scaledImage(texture, w, h [, fit_mode = ImGui.ImageScaleMode_LetterBox, keep_size = false, anchor_x = 0.5, anchor_y = 0.5, tint_col = 0xffffff, tint_alpha = 1, border_col = 0, border_alpha = 0, bg_col = 0, bg_alpha = 0, visibleAreaX = 0, visibleAreaY = 0, visibleAreaW = textureWidth, visibleAreaH = textureHeight, clampArea = false])

OR

ImGui:scaledImage(texture, w, h [, fit_mode = ImGui.ImageScaleMode_LetterBox, keep_size = false, anchor_x = 0.5, anchor_y = 0.5, tint_col = 0xffffff, tint_alpha = 1, border_col = 0, border_alpha = 0, bg_col = 0, bg_alpha = 0, table = {0, 0, textureWidth, textureHeight}, clampArea = false])

Same for others

If its not set, then used default values (but its different for TextureRegions)

keszegh said:

" I guess its impossible to put cursor at end of text. " - strange.

¯\_(ツ)_/¯

keszegh said:

about the suspend crash actually there is a gideros log too, i forgot to share:
Assertion failed!

Program: C:\Program Files (x86)\Gideros\GiderosPlayer.exe
File: refptr.cpp, Line 67

Expression: refcount_ == 1
AL lib: ALc.c:2325: exit(): closing 1 Device
AL lib: ALc.c:2247: alcCloseDevice(): destroying 1 Context(s)

Hm, ok, I'll try to figure it out... That's all ?

keszegh said:

you've recommended to replace my image+text with ImageWithText. actually my items are selectables, can one make an imagewithtext (or an image) part of the selectable?

(now when i hover on my image+selectable it highlights the text part but not the image, ideally it would also highlight the image background too, so i'm not 100% with my current solution anyway). see screenshot.

Hold on. Now its image + selectable, but before it was ... ?
Side question: is this in table or just:

imgui:beginChild() imgui:image() imgui:sameLine() imgui:selectable() imgui:endChild()

You can use table and use "ImGui.SelectableFlags_SpanAllColumns" flag, so that entire row will be highlighted.

keszegh

rrraptor said:

You can use table and use "ImGui.SelectableFlags_SpanAllColumns" flag, so that entire row will be highlighted.

that sounds really good, for me setting the flag it immediately made the scaledimage in the beginning part of the selectable (i did not even need any tables), which i'm really happy about. on the other hand it also 'greys' the image (the text correcty remains white), is there a way to avoid this?

keszegh

about suspend issue here is the debugview64 log:

[14144] 17:24:14.588 4 AudioDeviceSession OnStateChanged Inactive GiderosPlayer {0.0.0.00000000}.{c7c7e722-72dc-4179-9a88-f2b23710d84f}|\Device\HarddiskVolume4\Program Files (x86)\Gideros\GiderosPlayer.exe%b{00000000-0000-0000-0000-000000000000}|1%b16656
[14144] 17:24:14.607 5 ProcessWatcherService Quit: 16656
[14144] 17:24:14.607 5 AudioDeviceSession DisconnectSession GiderosPlayer {0.0.0.00000000}.{c7c7e722-72dc-4179-9a88-f2b23710d84f}|\Device\HarddiskVolume4\Program Files (x86)\Gideros\GiderosPlayer.exe%b{00000000-0000-0000-0000-000000000000}|1%b16656
[14144] 17:24:14.607 UI AudioDeviceSessionCollection RemoveSession GiderosPlayer {0.0.0.00000000}.{c7c7e722-72dc-4179-9a88-f2b23710d84f}|\Device\HarddiskVolume4\Program Files (x86)\Gideros\GiderosPlayer.exe%b{00000000-0000-0000-0000-000000000000}|1%b16656
[14144] 17:24:14.607 4 AudioDeviceSession OnStateChanged Expired GiderosPlayer {0.0.0.00000000}.{c7c7e722-72dc-4179-9a88-f2b23710d84f}|\Device\HarddiskVolume4\Program Files (x86)\Gideros\GiderosPlayer.exe%b{00000000-0000-0000-0000-000000000000}|1%b16656

keszegh

rrraptor said:

No problems for me
scaledImageButton

scaledImageButtonWithText

yes, that's how it should look like but i cannot achieve it. here is my code and endresult, perhaps you will realize what i'm doing wrong (is there perhaps some other style var which can introduce this artifact?):

imgui:pushStyleVar(ImGui.StyleVar_FramePadding,0,0) if (imgui:scaledImageButton(self.textureOrder, 12, 19, ImGui.ImageScaleMode_Stretch, false, 0, 0.5, 0.5, 0xffffff, 1, 0, 0, 0x3f3f3f, 0)) then self.orderedByType=not self.orderedByType self.cachedDirs.isUpdated=false end imgui:popStyleVar() self:showHelpText("order files first by type on/off") imgui:sameLine(0,0) local newValue=imgui:checkbox("",self.orderedByType)

keszegh

about the inputtext issues i have decided to give it a try on the main imgui github page:
https://github.com/ocornut/imgui/issues/4391

rrraptor

keszegh said:

rrraptor said:

No problems for me
scaledImageButton

scaledImageButtonWithText

yes, that's how it should look like but i cannot achieve it. here is my code and endresult, perhaps you will realize what i'm doing wrong (is there perhaps some other style var which can introduce this artifact?):

imgui:pushStyleVar(ImGui.StyleVar_FramePadding,0,0) if (imgui:scaledImageButton(self.textureOrder, 12, 19, ImGui.ImageScaleMode_Stretch, false, 0, 0.5, 0.5, 0xffffff, 1, 0, 0, 0x3f3f3f, 0)) then self.orderedByType=not self.orderedByType self.cachedDirs.isUpdated=false end imgui:popStyleVar() self:showHelpText("order files first by type on/off") imgui:sameLine(0,0) local newValue=imgui:checkbox("",self.orderedByType)

Have you tried to create empty project? Maybe something wrong with window scaling? Or another style var? And check ur atlas (text file) maybe?)

I tried both single texture and TextureRegion


Fixed issue with padding (values < 0), dll updated.

keszegh

rrraptor said:

Have you tried to create empty project? Maybe something wrong with window scaling? Or another style var? And check ur atlas (text file) maybe?)

i checked empty project, it worked. single file/atlas both worked. then i've noticed your note about scaling and indeed
ui:setScale(1.2) is which makes this mess. however, i'd be really happy if i could scale freely the gui, so i hope this can be corrected somehow.

keszegh

keszegh said:

i checked empty project, it worked. single file/atlas both worked. then i've noticed your note about scaling and indeed
ui:setScale(1.2) is which makes this mess. however, i'd be really happy if i could scale freely the gui, so i hope this can be corrected somehow.

0*1/2=0 after all...
seriously, i understand that rounding has to be applied when scaled but i think it's reasonable to expect that 0 becomes 0 whatever the scaling is.

rrraptor

@keszegh maybe u can use "IO:setFontGlobalScale(GLOBAL_SCALE)" instead?

keszegh

rrraptor said:

@keszegh maybe u can use "IO:setFontGlobalScale(GLOBAL_SCALE)" instead?

not really, setting it to 1.2 messes up my gui completely (while most buttons even remain the same size as with global scale 1).

rrraptor

I figured out the scaling problem. It happents because of image clipping. But it only works for FitWidth/FitHeight/KeepSize scale mode (technicaly it is alwasy on, but visualy there is no reason to apply it to Stretch/Letterbox modes).
So the question is: how to resovle the problem? I can add extra parameter (ClipImage or something), or I can disable it completely, or I can add "ClippingOffset" so that you can manualy adjust it. Or maybe apply clipping to FitWidth/FitHeight/KeepSize modes only?

keszegh

i don't really understand the differences, i guess what is simplest for you should be tried first. as far as i understand the last option you mentioned may be good enough. in any case let's try one of them. thanks

rrraptor

No clipping:

rrraptor

Updated
https://github.com/MultiPain/Gideros_ImGui#widgets-images

keszegh

keszegh said:

that sounds really good, for me setting the flag it immediately made the scaledimage in the beginning part of the selectable (i did not even need any tables), which i'm really happy about. on the other hand it also 'greys' the image (the text correcty remains white), is there a way to avoid this?

do you have any idea how not to grey out the images?

also let me recall two pending issues (hoping that in next gideros release all these may become fixed):

- crash on suspend when resetting keys/mouse

- ALT button registered wrongly by gideros functions

thanks a lot @rrraptor for making this priceless contribution called imgui plugin to gideros.

rrraptor

keszegh said:

do you have any idea how not to grey out the images?

In your case it seems like there is a transparent rectangle on top, so try to use tables API maybe?

Instead of "tableSetColumnIndex(i)" you can simply use "tableNextColumn()".

keszegh said:

- crash on suspend when resetting keys/mouse

Honestly, I have no idea how to fix it. There is no errors in imgui code, only in gideros.
But its ok if you do not call this reset functions?

keszegh said:

- ALT button registered wrongly by gideros functions

Im working on it

keszegh

rrraptor said:

keszegh said:

do you have any idea how not to grey out the images?

In your case it seems like there is a transparent rectangle on top, so try to use tables API, because it changes row background color, instead of overlapping rectangle

ok, i will try using a table.

rrraptor said:

keszegh said:

- crash on suspend when resetting keys/mouse

Honestly, I have no idea how to fix it. There is no errors in imgui code, only in gideros.
But its ok if you do not call this reset functions?

it was supposed to be a fix for when one is ALT-TABBING back and forth and alt gets fixed in imgui (and e.g. some slider gets 'slow'). i think this issue is still present.

rrraptor said:

keszegh said:

- ALT button registered wrongly by gideros functions

Im working on it

thanks

rrraptor

keszegh said:

it was supposed to be a fix for when one is ALT-TABBING back and forth and alt gets fixed in imgui (and e.g. some slider gets 'slow'). i think this issue is still present.

I understand.
I mean, from your logs I can see only gideros related code, but not imgui's.

keszegh

what is the most efficient way to add a horizontal spacing? i can do indent (And then unindent) or i can add a dummy(), latter seems most easy but i wonder if there is anything more intelligent. altogether i don't understand why there is nothing like spacing() for horizontal space, or am i missing something?

keszegh

rrraptor said:

In your case it seems like there is a transparent rectangle on top, so try to use tables API maybe?

thanks, it took some time to redo it with tables but at the end it indeed works as i want now and the code became nicer too.

keszegh

i've noticed that there is now clipping in scaledbutton, this solved my problem about the imgui global scaling introducing artifact borders. thanks

keszegh

btw a small inconsistency:
colorEdit3 and colorPicker4 with no alpha look slightly differently, in one of them it is written 'current' next to the current color and in the other there is nothing written there. it would be nice to add the text 'current' to the other too (which is colorPicker4).

keszegh

@rrraptor, now that most of my problems are gone, is there a progress about the 'ALT key' issues?

rrraptor

keszegh said:

@rrraptor, now that most of my problems are gone, is there a progress about the 'ALT key' issues?

Updated dll, you can test it now.

rrraptor

keszegh said:

btw a small inconsistency:
colorEdit3 and colorPicker4 with no alpha look slightly differently, in one of them it is written 'current' next to the current color and in the other there is nothing written there. it would be nice to add the text 'current' to the other too (which is colorPicker4).

Im to going to modify original widgets.