Shape:setFillStyle() crashing on Android without matrix as third argument

PaulH

In my pre-release testing using Gideros 2023.7 I'm seeing a crash when calling Shape:setFillStyle() without the third argument, an optional transformation matrix. Passing in Matrix.new() as a third argument seems to prevent it. The crash also happens on Android, but not on Windows.

MoKaLux

Hi PaulH I don't seem to have an issue with this on my android phone
I use this code for example:

-- image local img = Shape.new() img:setLineStyle(params.shapelinewidth, params.shapelinecolor, params.shapelinealpha) -- (width, color, alpha) if params.texpath then local tex if not params.istexpot then tex = Texture.new(params.texpath, false, {wrap = Texture.REPEAT, extend = false}) else tex = Texture.new(params.texpath, false, {wrap = Texture.REPEAT}) end local skewanglex = math.rad(params.skewx) local skewangley = math.rad(params.skewy) local matrix = Matrix.new(params.scalex, math.tan(skewanglex), math.tan(skewangley), params.scaley, 0, 0) img:setFillStyle(Shape.TEXTURE, tex, matrix) --> OK tex = nil elseif params.color then img:setFillStyle(Shape.SOLID, params.color) --> OK else img:setFillStyle(Shape.NONE) --> OK end

You can see three use case for setFillStyle and no crash so far using latest Gideros 2023.7

hgy29

I spotted the bug, it must have been there for years. I will fix it tomorrow.

PaulH

That's odd. This worked fine for me until I switched to 2023.7. But thanks for the fix!

hgy29

Fixed in https://github.com/gideros/gideros/commit/a09ac18a12a970e55f320583f1a58809af55a9d8.