imGui bindings

rrraptor · November 2020

Added demo to github:
https://github.com/MultiPain/Gideros_examples/tree/master/ImGuiFileDialogDemo

rrraptor · November 2020

Docs updated.
https://github.com/MultiPain/Gideros_ImGui/commit/cd0a8e6e29ef9d41699cc5cb7df976ecce42e75b

ImGui:calcTextSize() is changed:

--before
ImGui:calcTextSize(text, [text_end = nul, hide_text_after_double_hash = false, wrap_width = -1])
 
--after
ImGui:calcTextSize(text, [hide_text_after_double_hash = false, wrap_width = -1])

New docking functions

Hope I didnt miss anything...

Currently working on nav inputs, because I completely forgot about it

https://github.com/ocornut/imgui/issues/787

SinisterSoft · November 2020

Your plugin is looking amazing.

hgy29 · November 2020

IS it ready for including in 2020.11, or do you need time to polish it a bit more ?

rrraptor · November 2020

hgy29 said:
IS it ready for including in 2020.11, or do you need time to polish it a bit more ?

Ready, but nav inputs is not tested at all.

rrraptor · November 2020

Keyboard navigation:

-- in init function:
IO:addConfigFlags(ImGui.ConfigFlags_NavEnableKeyboard)
-- in enterFrame fill NavInput table like this (see enums):
if (UI:isKeyPressed(KeyCode.ENTER)) then IO:setNavInput(ImGui.NavInput_Activate, 1) end 
UI:newFrame(e)
if (UI:isKeyPressed(KeyCode.LEFT)) then IO:setNavInput(ImGui.NavInput_DpadLeft, 1) end
if (UI:isKeyPressed(KeyCode.RIGHT)) then IO:setNavInput(ImGui.NavInput_DpadRight, 1) end
if (UI:isKeyPressed(KeyCode.UP)) then IO:setNavInput(ImGui.NavInput_DpadUp, 1) end
if (UI:isKeyPressed(KeyCode.DOWN)) then IO:setNavInput(ImGui.NavInput_DpadDown, 1) end

List of KeyCodes that can be used with IO:isKeyDown/IO:isKeyPressed/IO:isKeyReleased

rrraptor · November 2020

@hgy29 sorry, but can you add something like this to init function?)

lua_Number getAppProperty(lua_State *L, const char* name)
{
    lua_getglobal(L, "application");
    lua_getfield(L, -1, name);
    lua_pushvalue(L, -2);
    lua_call(L, 1, 1);
    lua_Number value = lua_tonumber(L, -1);
    lua_remove(L, -1);
    return value;
}
 
int initImGui(lua_State* L)
{
...
io.DisplaySize.x = getAppProperty(L, "getContentWidth");
io.DisplaySize.y = getAppProperty(L, "getContentHeight");
...
}

I forgot to set display size by default

rrraptor · November 2020

Examples updated, added a link to save/open dialog example.
https://wiki.gideros.rocks/index.php/Dear_ImGui

hgy29 · November 2020

I didn't update yet, will do now, with your latest changes

hgy29 · November 2020

@rraptor, I have trouble compiling imgui for win32 now, it complains about duplicate symbols:

Build/Common/imgui_user.o:imgui_user.cpp:(.text+0x28c0): multiple definition of `ImGui::TextEx(char const*, char const*, int)'
Build/Common/imgui_src/imgui_widgets.o:imgui_widgets.cpp:(.text+0x28c0): first defined here
Build/Common/imgui_user.o:imgui_user.cpp:(.text+0x2da0): multiple definition of `ImGui::TextUnformatted(char const*, char const*)'
Build/Common/imgui_src/imgui_widgets.o:imgui_widgets.cpp:(.text+0x2da0): first defined here
Build/Common/imgui_user.o:imgui_user.cpp:(.text+0x2dd0): multiple definition of `ImGui::TextV(char const*, char*)'
Build/Common/imgui_src/imgui_widgets.o:imgui_widgets.cpp:(.text+0x2dd0): first defined here
Build/Common/imgui_user.o:imgui_user.cpp:(.text+0x2e40): multiple definition of `ImGui::Text(char const*, ...)'
Build/Common/imgui_src/imgui_widgets.o:imgui_widgets.cpp:(.text+0x2e40): first defined here
...

I see that imgui_user.cpp includes imgui_widgets.cpp, which cause the issues since imgui_widgets.cpp is already compiled on its own. How to fix this ?

rrraptor · November 2020

hgy29 said:

@rraptor, I have trouble compiling imgui for win32 now, it complains about duplicate symbols:

Build/Common/imgui_user.o:imgui_user.cpp:(.text+0x28c0): multiple definition of `ImGui::TextEx(char const*, char const*, int)'
Build/Common/imgui_src/imgui_widgets.o:imgui_widgets.cpp:(.text+0x28c0): first defined here
Build/Common/imgui_user.o:imgui_user.cpp:(.text+0x2da0): multiple definition of `ImGui::TextUnformatted(char const*, char const*)'
Build/Common/imgui_src/imgui_widgets.o:imgui_widgets.cpp:(.text+0x2da0): first defined here
Build/Common/imgui_user.o:imgui_user.cpp:(.text+0x2dd0): multiple definition of `ImGui::TextV(char const*, char*)'
Build/Common/imgui_src/imgui_widgets.o:imgui_widgets.cpp:(.text+0x2dd0): first defined here
Build/Common/imgui_user.o:imgui_user.cpp:(.text+0x2e40): multiple definition of `ImGui::Text(char const*, ...)'
Build/Common/imgui_src/imgui_widgets.o:imgui_widgets.cpp:(.text+0x2e40): first defined here
...

I see that imgui_user.cpp includes imgui_widgets.cpp, which cause the issues since imgui_widgets.cpp is already compiled on its own. How to fix this ?

Well, I tried to get rid of duplicated function...
You can add "GDataTypeInfo" and "PatchFormatStringFloatToInt" from here I guess:
and remove include
https://github.com/MultiPain/Gideros_ImGui/blob/ebcd783787440438ec850e81e6dcefa85ffd990f/imgui_user.cpp

hgy29 · November 2020

I see, thanks

rrraptor · November 2020

If someone wants to use imgui with SceneManager, do not forget to destroy your imgui object when changing scene!
One way to do it:

function MyScene:init()
	self.imgui = ImGui.new()
	self:addChild(self.imgui)
	--...
	self:addEventListener("exitBegin", self.exitBegin, self)
end
--
function MyScene:exitBegin()
	self:removeAllListeners() -- remove "enterFrame" event OR all event if you want
	self.imgui = nil -- destroy imgui
end

Also, Ive fixed a bug with mouse coordinates in event callbacks (ImGui:onMouseMove(e) and others).

rrraptor · November 2020

Actually, that wont really help... So for now, use single ImGui instance instead. I'll investigate the problem...

rrraptor · November 2020

So basically you must use single ImGui object, because ImGui itself is not defined as class. Ive added simple assertion:
https://github.com/MultiPain/Gideros_ImGui/commit/3d672db9ae0a17214e60958dcb726e0efb29477d?branch=3d672db9ae0a17214e60958dcb726e0efb29477d&diff=unified#diff-608d8de3fba954c50110b6d7386988f27295de845e9d7174e40095ba5efcf1bbR1203

rrraptor · November 2020

Fixing images functions.

rrraptor · November 2020

Done.

New functions will keep original image ratio.

https://github.com/MultiPain/Gideros_ImGui/commit/9e319169bfef60a64a40878cd6c0e492568b1185

Removed UV's args because of TextureRegion object.

P.S. Added Node Editor(work in progress

), but only in docking branch.

rrraptor · November 2020

Made a simple grid editor using imgui

Grid drawn by imgui, drag&drop handled by imgui

keszegh · November 2020

The grid editor is really nice and the animations in the played stuff too.

rrraptor · November 2020

@hgy29 can you help again?

Seems like drag&drop payload does not work correctly.
To put data into storage we use

ImGui:setStrDragDropPayload("IDENTIFIER_STRING", stringData)

and c++

int SetStringDragDropPayload(lua_State* L)
{
    const char* type = luaL_checkstring(L, 2);
    const char* str = luaL_checkstring(L, 3);
 
    ImGuiCond cond = luaL_optinteger(L, 4, 0);
    lua_pushboolean(L, ImGui::SetDragDropPayload(type, str, strlen(str), cond));
    return 1;
}

When you need to get this data back:

local payload = ImGui:acceptDragDropPayload("IDENTIFIER_STRING")
local stringData = payload:getStrData()

in c++:

int Payload_GetStringData(lua_State* L)
{
    ImGuiPayload* payload = getPayload(L);
    const char* str = static_cast<const char*>(payload->Data);
    lua_pushstring(L, str);
    return 1;
}

And it works OK for some strings and does not for others.
For example:

{"name":"2way","r":270} -- OK
{"name":"1way","r":180} -- OK
{"name":"star","r":0} -- OK
{"name":"line","r":270} -- OK
{"name":"deflector","r":0}q�[q���` -- NOT OK!

As you can see there is some strange symbols at the end... Idk how to fix it, maybe you can guide me ?

ImGui::SetDragDropPayload:
https://github.com/ocornut/imgui/blob/71cc636696bd17c81514da49707e909958c14632/imgui.cpp#L9453

ImGuiPayload:
https://github.com/ocornut/imgui/blob/71cc636696bd17c81514da49707e909958c14632/imgui.h#L1682

hgy29 · November 2020

When you give the payload to imgui, you give the string pointer and the string size, so imgui stores the exact number of characters the string has, without the extra zero char strings have in C. This is OK.
However when you get back the payload from imgui, you push it to lua without telling the string size, so lua compute the size by looking for the zero char at the end of the string, which might no be there.

You need to use

lua_pushlstring(L, str, strSize)

(notice the 'l' in lua_pushlstring)

rrraptor · November 2020

hgy29 said:
When you give the payload to imgui, you give the string pointer and the string size, so imgui stores the exact number of characters the string has, without the extra zero char strings have in C. This is OK.
However when you get back the payload from imgui, you push it to lua without telling the string size, so lua compute the size by looking for the zero char at the end of the string, which might no be there.

You need to use
lua_pushlstring(L, str, strSize)
(notice the 'l' in lua_pushlstring)

Ty, works great

rrraptor · November 2020

@keszegh can you check if "CTRL", "ALT" and "SHIFT" keys works with latest version in html?
You can use

IO = ImGui:getIO()
bool = IO:isKeyCtrl()
bool = IO:isKeyShift()
bool = IO:isKeyAlt()

keszegh · November 2020

@rrraptor, thanks, i shall test it as soon as i can, but it will be a few days i'm afraid.

keszegh · November 2020

your plugin could be added here:
https://github.com/ocornut/imgui/wiki/Bindings

keszegh · November 2020

when i compile it to html then i get this error:
"C:\Program Files (x86)\Gideros\Tools\luac.exe: API.lua:8: '+=','-=','*=', '/=', '%=', '^=', '=' expected near 'ImGui'"
and when i run the code it does nothing after the gideros loading screen.

EDIT: the export not working is probably due to the same bug as reported here:
http://forum.giderosmobile.com/discussion/8341/html5-function-import-requires-a-callable#latest

keszegh · November 2020

@rrraptor ,i've also sent a pm about imgui+html.

keszegh · December 2020

2020.12 can export again html5 properly, so new pm sent. in short: ctrl and shift works, alt does not.

rrraptor · December 2020

keszegh said:
2020.12 can export again html5 properly, so new pm sent. in short: ctrl and shift works, alt does not.

Ty. Honestly, idk why alt does not work

This is the code:

@hgy29 any thoughts?

Seems like 1.80 coming soon. There was tons of commits today

rrraptor · December 2020

Here is new images functions:
https://github.com/MultiPain/Gideros_ImGui#widgets-images

Howdy, Stranger!

Categories

In this Discussion

Top Posters

imGui bindings

Comments

Howdy, Stranger!

Quick Links

Categories

In this Discussion

Top Posters

imGui bindings

Comments